[WIP] Hensel lift and zassenhaus #1066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symengine/polys/uintpoly.h
Outdated
| std::vector<UIntDict> zz_hensel_lift(const integer_class &p, | ||
| const std::vector<UIntDict> &f_list, | ||
| unsigned int l) const; | ||
| static void zz_divide(const UIntDict &a, const UIntDict &b, |
There was a problem hiding this comment.
Can you describe each of the methods above as a comment?
|
Otherwise it looks like it's working. Great job! What needs to be done to finish this PR? |
|
@certik I will have to write the |
symengine/fields.cpp
Outdated
| s1 *= inv; | ||
| t0 = t1; | ||
| t1 = *t; | ||
| t1 *= inv; |
There was a problem hiding this comment.
This is making copies too much. Can you reduce copying here?
|
@certik I will have to write the factor square free method then this can be merged.
After which in a different PR, I would like to implement the get square free part and factor method.
If you can implement the factor() method, that would be very useful.
It would be relatively easy for you, but much harder if other people
have to go into this and learn what you did and finish it. Let me know
if you need any help with this.
Ondrej
|
|
@certik Yes sure! I will try to complete it by this week. |
symengine/fields.cpp
Outdated
| *t = t0 - t1 * Q; | ||
|
|
||
| s0 = s1; | ||
| s1 = (*s) * inv; |
There was a problem hiding this comment.
what you basically want to do here is s0, s1 = s1, (s0 - s1 *Q) * inv.
How about this?
s0 = (s0 - s1 *Q) * inv;
swap(s0, s1);
symengine/polys/uintpoly.cpp
Outdated
| std::vector<unsigned int> T_S(T.size()); | ||
| auto it = std::set_difference(T.begin(), T.end(), S.begin(), | ||
| S.end(), T_S.begin()); | ||
| T_S.resize(it - T_S.begin()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It factors a primitive polynomial in integer domain.
Implements extended GCD in finite fields.
And a small bug fix in
UIntPoly::mul